From 04639a6ad8c5c033e5e8dc6a1d444517e81b20c5 Mon Sep 17 00:00:00 2001 From: David Ludwig Date: Sat, 1 May 2021 23:04:52 -0500 Subject: [PATCH] Clean up services and remove no-op boot/shutdown methods --- services/request/src/server/services/Database.ts | 4 +++- services/request/src/server/services/DiscordBot.ts | 5 +++-- services/request/src/server/services/MovieSearch.ts | 11 +++-------- services/request/src/server/services/PlexLibrary.ts | 9 +++------ services/request/src/server/services/TvDb.ts | 11 +++-------- .../request/src/server/services/WebServer/index.ts | 7 ++++++- 6 files changed, 21 insertions(+), 26 deletions(-) diff --git a/services/request/src/server/services/Database.ts b/services/request/src/server/services/Database.ts index 8e75fb2..6ab5ac2 100644 --- a/services/request/src/server/services/Database.ts +++ b/services/request/src/server/services/Database.ts @@ -14,7 +14,9 @@ export default class Database extends InternalService /** * The name of the service */ - public get name() { return "Database" } + public get name() { + return "Database"; + } /** * Boot the database service diff --git a/services/request/src/server/services/DiscordBot.ts b/services/request/src/server/services/DiscordBot.ts index 73fc8a8..8d2ccd0 100644 --- a/services/request/src/server/services/DiscordBot.ts +++ b/services/request/src/server/services/DiscordBot.ts @@ -92,7 +92,9 @@ export default class DiscordBot extends InternalService /** * The service name */ - public get name() { return "Discord Bot" } + public get name() { + return "Discord Bot"; + } /** * Boot the discord bot @@ -118,7 +120,6 @@ export default class DiscordBot extends InternalService */ public async shutdown() { this.bot.destroy(); - } // Message Handling ---------------------------------------------------------------------------- diff --git a/services/request/src/server/services/MovieSearch.ts b/services/request/src/server/services/MovieSearch.ts index 815c8e7..d352290 100644 --- a/services/request/src/server/services/MovieSearch.ts +++ b/services/request/src/server/services/MovieSearch.ts @@ -35,7 +35,9 @@ export default class MovieSearch extends InternalService /** * The name of the service */ - public get name() { return "Movie Search" } + public get name() { + return "Movie Search"; + } /** * Start the service @@ -52,13 +54,6 @@ export default class MovieSearch extends InternalService this.tmdb = new TheMovieDb(apiKey); } - /** - * Shutdown the service - */ - public async shutdown() { - // no-op - } - /** * Store an IMDb ID in cache */ diff --git a/services/request/src/server/services/PlexLibrary.ts b/services/request/src/server/services/PlexLibrary.ts index 0adda37..59b1fcf 100644 --- a/services/request/src/server/services/PlexLibrary.ts +++ b/services/request/src/server/services/PlexLibrary.ts @@ -38,7 +38,9 @@ export default class PlexLibrary extends InternalService /** * The service name */ - public get name() { return "Plex Library" } + public get name() { + return "Plex Library"; + } /** * Boot the Plex library service @@ -55,11 +57,6 @@ export default class PlexLibrary extends InternalService this.updateMovies(); } - /** - * Shutdown the Plex library service - */ - public async shutdown() {} - /** * Update the movie catalog */ diff --git a/services/request/src/server/services/TvDb.ts b/services/request/src/server/services/TvDb.ts index 352b800..53e89a2 100644 --- a/services/request/src/server/services/TvDb.ts +++ b/services/request/src/server/services/TvDb.ts @@ -23,7 +23,9 @@ export default class TvDb extends InternalService /** * The service name */ - public get name() { return "TVDB" } + public get name() { + return "TVDB"; + } /** * Boot the service @@ -34,13 +36,6 @@ export default class TvDb extends InternalService await this.refreshLogin(); } - /** - * Shutdown the service - */ - public async shutdown() { - // no-op - } - /** * Refresh the login token if necessary */ diff --git a/services/request/src/server/services/WebServer/index.ts b/services/request/src/server/services/WebServer/index.ts index 4b8dd7f..47e4a32 100644 --- a/services/request/src/server/services/WebServer/index.ts +++ b/services/request/src/server/services/WebServer/index.ts @@ -32,7 +32,12 @@ export default class WebServer extends InternalService this.fastify = fastify(); } - public get name() { return "Web Server" } + /** + * The service name + */ + public get name() { + return "Web Server"; + } /** * Register required Fastify plugins